Use UnitControl for font-size #31314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
requested review from
youknowriad,
kjellr,
carolinan,
jorgefilipecosta,
epiqueras and
sarayourfriend
|
Size Change: +176 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
@carolinan tbh I don't know... Whatever the plan however, font-sizes should not, under any circumstances, be limited to |
This comment has been minimized.
This comment has been minimized.
|
The G2 version of the font size picker is gone for now, to be later re-implemented once its dependencies are migrated. When it's re-implemented we can make sure that it uses UnitControl 👍 That way we don't introduce a regression. |
Yeah, that is the same for all
|
aristath
force-pushed
the
add/font-size-unitcontrol
branch
from
ddd2b50 to
7c27cac
Compare
|
All tests now pass 🎉 |
carolinan
approved these changes
Apr 30, 2021
youknowriad
added
the
[Feature] Design Tools
youknowriad
reviewed
Apr 30, 2021
| onChange( nextSize ); | ||
| } | ||
| } } | ||
| units={ CSS_UNITS } |
There was a problem hiding this comment.
I think themes can control the available units or disable them, is this being taken into consideration here?
|
This is cool. One thing I'm using on my own site, which isn't quite launched yet, is
It might be fun to explore some clamp usage in the future to have some intrinsic responsiveness, but that's a thought for another day. |
7 tasks
I do the same... but I do it for all elements of a page. So the |
|
Just to follow up, I explored query-less responsiveness a bit more in this codepen. I also leveraged some of that for my theme. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows using non-px values for font-sizes, by using
UnitControlinstead of the custom number input we were previously using.Font-sizes were previously saved using
pxas a hardcoded unit, so there are no backwards-compatibility issues I could find. This just allows usingem/remunits.How has this been tested?
Tested in new blocks, tested in existing posts, nothing breaks. Tested using px, em & rem values. nothing breaks.
Screenshots
Before:
After:
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).