Editor: Wire PHP tests for block editor settings #30984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Automated Testing
gziolo
commented
Apr 20, 2021
gziolo
changed the title
|
Size Change: 0 B Total Size: 1.46 MB ℹ️ View Unchanged
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #30245.
I missed one tiny but extremely important detail, PHPUnit test files need to end with
-test.php. The fact that I extracted code from WordPress/wordpress-develop#1118 didn't help as well 😅I had to update some tests in comparison to the version in WordPress core to account for the hooks that are present in the Gutenberg plugin.
How has this been tested?
npm run test-php- ensure that tests run and pass.Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).