Add translation context to all block's titles #27933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
ajitbohra,
ajlende,
mkaz,
mkevins and
talldan
as code owners
oandregal
added
the
Internationalization (i18n)
|
Size Change: +91 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
Thank you for doing it. It only confirms that the planned work to move all translatable fields to |
|
If the title is moved to the block.json I guess it can also add the context automatically (and the same for any other strings), translators will love to have that. Same with theme.json. |
FWIW The WP-CLI string extraction for The PHP implementation to actually load the translations would need to do the same. |
swissspidy
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the context in which a string is used to all block's titles, so translators know where these are used.
After translating a few strings myself via GlotPress for the Gutenberg plugin I realized some block titles were actually translated as verbs, not nouns. For example, Query Loop was translated in the Spanish locale as "Consultar el loop" (verb, like "query the loop"), instead of "Bucle de Consulta" (a compound noun). The example is just one of many that I also found in different languages and it's not meant to diminish any particular translation. If anything, this PR is an empathetic effort to make translators' life easier by giving them more context.
The blocks with compound nouns (post page, query loop) can be more prone to this kind of error, but there's also single-noun names that can be affected (quote => cita as noun, citar as verb), hence why I decided to set it up for all the blocks.