Fix list block not properly aligned #21971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Regression
|
Size Change: +4 B (0%) Total Size: 816 kB
ℹ️ View Unchanged
|
|
To clarify, the idea is to restore the same amount of specificity which existed for these specific styles that had existed with this removed code? https://github.com/WordPress/gutenberg/pull/20951/files#diff-947e2eca7278f9a543620b68d7187d09 |
Yes and at the same time, keep the patterns centered properly (no edit-post classnames) |
|
I tested: lists (and other random blocks) in the editor, block examples, and patterns. Everything seems fine. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #21961
In #20951 I updated the "centering" of blocks to avoid relying on
editor-*classNames. The idea is that the blocks should be centered regardless of the context of the block editor. This fixed the issue we had with block previews not centered properly.But the reduced specificity cause conflicts with editor styles (list), so lists were not aligned properly. This PR restores the level of specificity but keeps the generic styles solving both issues at the same time.
Testing instructions