Social Links: Add disableSuggestions to URLInput #18946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #18905 Social Links was switched from a generic input field to using URLInput, this change adds disableSuggetions to prevent the field to suggest internal links or pages since Social Links are typically an external link.
mkaz
added
the
[Block] Social
jasmussen
approved these changes
Dec 6, 2019
|
Based on the screenshot, I might think the loaded is unnecessary when the suggestions are disabled. The API shouldn't be called at all? |
|
It could be a separate fix though as it seems that this prop already exists. |
aduth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #18905 Social Links was switched from a generic input field to using URLInput, this change adds disableSuggetions to prevent the field to suggest internal links or pages since Social Links are typically an external link.
Related, but not dependent, the Social Links can probably also benefit from this issue
#11852
How has this been tested?
Base Case. Add a Social Links block, insert a link and in the URL field type "About" or other page or post name and you should see a list of suggestions.
Apply PR. Repeat 1 and as you start typing you should not see the suggestions
Types of changes
Adds disableSuggestions parameter to URLInput component for Social Links.
Checklist: