From ca40e24e118a92ee3ec74a44a3afe680cf708640 Mon Sep 17 00:00:00 2001 From: Riad Benguella Date: Mon, 7 Oct 2019 09:41:11 +0100 Subject: [PATCH 1/2] Disable the navigation mode when clicking the redirect element --- packages/block-editor/src/components/writing-flow/index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/block-editor/src/components/writing-flow/index.js b/packages/block-editor/src/components/writing-flow/index.js index 54e1a7ee77fe08..37e45dd2680d0d 100644 --- a/packages/block-editor/src/components/writing-flow/index.js +++ b/packages/block-editor/src/components/writing-flow/index.js @@ -377,6 +377,7 @@ class WritingFlow extends Component { * Sets focus to the end of the last tabbable text field, if one exists. */ focusLastTextField() { + this.disableNavigationMode(); const focusableNodes = focus.focusable.find( this.container ); const target = findLast( focusableNodes, isTabbableTextField ); if ( target ) { From 0b1dc0680a9e0abbaef5ea3d2b9b74db59b043c5 Mon Sep 17 00:00:00 2001 From: Riad Benguella Date: Wed, 9 Oct 2019 11:36:17 +0100 Subject: [PATCH 2/2] run the test in navigation mode --- packages/e2e-tests/specs/adding-blocks.test.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/e2e-tests/specs/adding-blocks.test.js b/packages/e2e-tests/specs/adding-blocks.test.js index ed44aa7817e2ad..56e5976513746d 100644 --- a/packages/e2e-tests/specs/adding-blocks.test.js +++ b/packages/e2e-tests/specs/adding-blocks.test.js @@ -29,6 +29,9 @@ describe( 'adding blocks', () => { } it( 'Should insert content using the placeholder and the regular inserter', async () => { + // This ensures the editor is loaded in navigation mode. + await page.reload(); + // Click below editor to focus last field (block appender) await clickBelow( await page.$( '.block-editor-default-block-appender' ) ); expect( await page.$( '[data-type="core/paragraph"]' ) ).not.toBeNull();