Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default state for the menu #17637

Merged
merged 4 commits into from
Oct 3, 2019
Merged

default state for the menu #17637

merged 4 commits into from
Oct 3, 2019

Conversation

draganescu
Copy link
Contributor

@draganescu draganescu commented Sep 28, 2019 •
edited
Loading

Description

Closes #17541

How has this been tested?

Tested locally.

default-menu-items

Types of changes

Wrapped the menu in a select looking for top level pages.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@draganescu draganescu force-pushed the update/nav-block-default-state branch from cb423b0 to 4478c9f Compare October 1, 2019 09:48
jorgefilipecosta
jorgefilipecosta approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected I just left a possible performance optimization that I think we should apply before the merge.

packages/block-library/src/navigation-menu/edit.js Outdated Show resolved Hide resolved
@draganescu draganescu force-pushed the update/nav-block-default-state branch from 9c62d71 to 13b003f Compare October 3, 2019 06:31
@draganescu draganescu merged commit 7e9aa07 into master Oct 3, 2019
@draganescu draganescu deleted the update/nav-block-default-state branch October 3, 2019 08:08
@youknowriad youknowriad added this to the Gutenberg 6.7 milestone Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 6.7
Development

Successfully merging this pull request may close these issues.

Navigation block: Add initial state
3 participants
@draganescu @jorgefilipecosta @youknowriad