Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adhere to platform standards in displaying keyboard shortcuts #9226

Closed
jasmussen opened this issue Aug 22, 2018 · 0 comments · Fixed by #9429
Closed

Adhere to platform standards in displaying keyboard shortcuts #9226

jasmussen opened this issue Aug 22, 2018 · 0 comments · Fixed by #9429
Labels
[Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone
3.7

Comments

@jasmussen
Copy link
Contributor

As discussed in #9190 (comment), let's consider adhering to platform standards for displaying shortcut keys in menus. This is not so much about saving space, and more tapping into the same language that the browser and operating system on which the editor runs.

For Windows, that's a verbose Control+Shift+B (note the plusses) as an example, whereas on a Mac the same might be ^⇧B (note the lack of plusses). Here are some screenshots:

Mac:

44402329-ba388380-a551-11e8-98b6-6e124dad1d90

44403193-17353900-a554-11e8-9632-211d87c576ca

Windows:

44402481-316e1780-a552-11e8-8df0-134278ad82ee

We'd want to show that pattern in these places and any others:

screen shot 2018-08-22 at 08 50 26

screen shot 2018-08-22 at 08 50 29

screen shot 2018-08-22 at 08 50 35

CC: @tofumatt
@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label Aug 22, 2018
@mtias mtias added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Aug 22, 2018
@mtias mtias added this to the 3.7 milestone Aug 22, 2018
jasmussen added a commit that referenced this issue Aug 29, 2018
@jasmussen
Adhere to Mac platform when showing shortcuts on a Mac
50e4d9c 
This fixes #9226.

This changes the display of keyboard shortcuts on the Mac to:

- not have the plus between
- use unicode symbols for the characters

The larger discussion for why we're doing this is in the ticket referenced, but the gist of it is: this is what MacOS does, and we mean to tap into that same pattern that Mac users will be used to.
@jasmussen jasmussen mentioned this issue Aug 29, 2018
Merged
youknowriad pushed a commit that referenced this issue Aug 30, 2018
@jasmussen @youknowriad
Adhere to Mac platform when showing shortcuts on a Mac (#9429)
774ccda 
* Adhere to Mac platform when showing shortcuts on a Mac

This fixes #9226.

This changes the display of keyboard shortcuts on the Mac to:

- not have the plus between
- use unicode symbols for the characters

The larger discussion for why we're doing this is in the ticket referenced, but the gist of it is: this is what MacOS does, and we mean to tap into that same pattern that Mac users will be used to.

* Fix tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
3.7
Development

Successfully merging a pull request may close this issue.

Adhere to Mac platform when showing shortcuts on a Mac WordPress/gutenberg
2 participants
@mtias @jasmussen