Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block audit: Columns #9156

Closed
11 tasks
sarahmonster opened this issue Aug 20, 2018 · 7 comments
Closed
11 tasks

Block audit: Columns #9156

sarahmonster opened this issue Aug 20, 2018 · 7 comments
Assignees
Labels
[Block] Columns Affects the Columns Block [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@sarahmonster
Copy link
Member

sarahmonster commented Aug 20, 2018

Block audit

Note: We'll be doing these audits in waves and editing this as we work through the blocks, so this text will be updated and fleshed out as we progress. See the full picture here.

Overview

screenshot 2018-08-15 10 56 26

Name: Columns (beta)
Description: Add a block that displays content in multiple columns, then add whatever content blocks you’d like.
Category: Layout elements
CSS class: wp-block-columns in editor and frontend
Can be converted to: nothing

Individual column block
Description: A single column within a columns block.
Advanced: Additional CSS class.

States

Empty:
screenshot 2018-08-20 11 35 24

Selected:
screenshot 2018-08-15 10 53 00

screenshot 2018-08-15 10 56 20

Unselected:
screenshot 2018-08-15 10 55 23

Placeholder:
screenshot 2018-08-20 11 35 34

Primary (toolbar) settings

None

Secondary (sidebar) settings

Columns (number)
Advanced: Additional CSS Class

Frontend appearance

Gutenberg starter theme:
screenshot 2018-08-20 11 56 28

Atomic Blocks
screenshot 2018-08-20 11 55 28

twentyseventeen:

screenshot 2018-08-20 11 49 36

twentyten:
screenshot 2018-08-20 11 57 36

Bugs/errors

Individual issues will be opened for these soon

Suggestions

Individual issues will be opened for these soon

  • Being able to select the individual columns maybe isn't strictly necessary. The only thing you can do with them is add a CSS class. Why not just add a CSS class to begin with?

  • I wonder if this might make more sense as an option within a container/section block, rather than its own block.

  • Full-width alignment here could be very nice.

  • Empty and placeholder states could use some consideration—they feel a bit confusing as it currently stands.

  • Overall, this block just feels confusing across the board, and I'm not sure that putting a "beta" flag in the title helps a great deal, particularly when the entire software is still in some form of beta or another.

@sarahmonster sarahmonster changed the title Columns Block audit: Columns Aug 20, 2018
@sarahmonster sarahmonster self-assigned this Aug 20, 2018
@sarahmonster sarahmonster added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Blocks Overall functionality of blocks labels Aug 20, 2018
@buzucan
Copy link

buzucan commented Aug 20, 2018

Another bug found. If I add some info in columns and after that I will save the info to a reusable block when I try to use the info from the block ...all is deleted.

@ZebulanStanphill
Copy link
Member

The Columns block should almost definitely not be part of a Container block, in my opinion. I think a Container block should focus on non-column-based layout options, like what Oxygen does:
https://oxygenbuilder.com/documentation/visual-editing/layout-spacing/
https://oxygenbuilder.com/documentation/visual-editing/responsive-controls/

I wonder if perhaps the Column (not Columns) blocks could be replaced by the future Container block, though. That sounds like something that would make sense, assuming there are no kinds of settings that you would want to modify for an individual Column block that would not make sense in a standalone Container block.

The Columns block definitely needs to get better responsiveness before the merge proposal, in my opinion. #8979 fixes some of the issue, but not all of it. For a temporary solution until Gutenberg switches to more of a page building focus, there was discussion in #6048 of adding a toggle to enable hardcoded responsive breakpoints for the Columns block.

There are various other issues with the Columns block which have tickets open. Here is a list of some of the major ones I could find:

It should also be noted that various other issues such as the following also have a significant effect on the Columns block:

@dionysous
Copy link

dionysous commented Aug 30, 2018

It should be possible to change the columns block to the setting "1 column" - there are many use cases where you need one column like a wrapper with a class, when you want to have an area of different color or background in the fontend.

At the moment it is not possible to drag the selector to the value of 1, but it is possible to delete the value and type "1" in the settings sidebar.

Edit: Or it could be solved with a wrapper / container / section block: #4900

@grappler
Copy link
Member

grappler commented Sep 4, 2018

I struggled with two things related to columns.

I created a 2 columns and added content, then I decided that I did not want to use columns but I could not find an easy way to move the block inside the columns to out of it.

As I hack I changed the number of columns to 1 using @dionysous tip and I lost all of the content in column 2 which was a bit unexpected.

@apeatling
Copy link
Contributor

There is a bug where if you select a single column and set an additional CSS class, it is not added to the markup. It does however appear in the markup on front end of the site.

@erikjoling
Copy link

I'd like to add investigating the markup of the columns-block in the editor to the audit #7770

@iandunn iandunn added the [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. label Jun 3, 2019
@karmatosed
Copy link
Member

I think with all the work going on in other issues this can maybe be closed now. With that in mind, I will do that but we can always reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests

9 participants