Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block audit: Table #8398

Closed
1 of 8 tasks
kjellr opened this issue Aug 2, 2018 · 2 comments
Closed
1 of 8 tasks

Block audit: Table #8398

kjellr opened this issue Aug 2, 2018 · 2 comments
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@kjellr
Copy link
Contributor

kjellr commented Aug 2, 2018

Note: We'll be doing these audits in waves and editing this as we work through the blocks, so this text will be updated and fleshed out as we progress. See the full picture here.

Overview

screen shot 2018-08-02 at 1 15 22 pm

Name: Table
Description: Insert a table -- perfect for sharing charts and data.
Category: Formatting
CSS class: wp-block-table in frontend and editor
Can be converted to: Nothing

States

Empty:

screen shot 2018-08-02 at 2 02 44 pm

Selected:

screen shot 2018-08-02 at 2 08 53 pm

Unselected:

screen shot 2018-08-02 at 2 08 25 pm

Placeholder:

screen shot 2018-08-02 at 2 02 44 pm

(Same as empty)

Primary (toolbar) settings

  • Align left
  • Align center
  • Align right
  • Edit table
    • Add row before
    • Add row after
    • Delete row
    • Add column before
    • Add column after
    • Delete column
  • Bold
  • Italic
  • Strikethrough
  • Link

Secondary (sidebar) settings

Table Settings: Fixed width table cells
Advanced: Additional CSS Class

Frontend appearance

Gutenberg starter theme:

screen shot 2018-08-02 at 3 24 52 pm

Atomic Blocks

screen shot 2018-08-02 at 3 25 30 pm

twentyseventeen:

screen shot 2018-08-02 at 3 25 10 pm

twentyten:

screen shot 2018-08-02 at 3 24 11 pm

Documentation

No devdocs in https://github.com/WordPress/gutenberg/tree/master/core-blocks/table

Suggestion for user-facing docs:

Performance on mobile

Accessibility

Bugs/errors

Individual issues will be opened for these soon

Suggestions

Individual issues will be opened for these soon

  • I expected to be able to adjust text color/backgrounds. In this case, I assume that those settings would apply to the current cell. (Consider adding color and text size customizations to all text-based blocks.  #8171)
  • It'd be great to add some "advanced" table features into the sidebar. There's a great discussion around this in Table block: flesh out editor features #6923
  • Customizing tables would be much faster if the "Edit table" options were exposed in the block toolbar. That said, that might lead to icon overload, and the icons may not be particularly clear on their own. Trusting my gut on this one — this would be too many icons in the toolbar.
  • Alignment feels a bit unexpected—it's using the block-level alignment icons and styling, but that doesn't seem to behave consistently. For instance, if I right-align the table, the text remains left-aligned, but if I centre-align the table, the text becomes centre-aligned. (Issue no longer occurs after the table block rewrite.)
  • Being able to set column and row headings would help improve accessibility of content to screenreader users. (Tables: no method to define row or column header cells (th) #1470)
@kjellr kjellr added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Blocks Overall functionality of blocks labels Aug 2, 2018
@kjellr kjellr self-assigned this Aug 2, 2018
@ellatrix
Copy link
Member

Just noting here that the table block has been rewritten recently, so the description may no longer be up to date.

@kjellr
Copy link
Contributor Author

kjellr commented Jan 18, 2019

All the issues raised here have been opened as individual issues. Going to close this for now, and we can continue discussion in the individual issues instead. 👍

Thanks!

@kjellr kjellr closed this as completed Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

2 participants