Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Image: Change the label from "Background Dimness" to "Background Opacity" #7853

Closed
BronsonQuick opened this issue Jul 10, 2018 · 1 comment

Comments

@BronsonQuick
Copy link
Contributor

Issue Overview

While testing the cover image block I thought that "dimness" isn't a frequently used word and "opacity" is a better word for this label.

Steps to Reproduce

  1. Insert a Cover Image block.
  2. Upload or Select an Image to use.
  3. Observe the "Background Dimness" label.

Expected Behavior

The label should say "Background Opacity".

Screenshots / Video

background-dimness

Related Issues and/or PRs

@melchoyce suggested either "Dimness" or "Opacity" here. I asked a few other people their thoughts and they agreed that opacity is a better fit.

Additional Info

Gutenberg @ c314b15

@maddisondesigns
Copy link

+1 for Opacity

ntwb pushed a commit that referenced this issue Jul 10, 2018
…d Opacity". (#7854)

Fixes #7853.

## Description
I've change the label on the Cover Image block "Background Dimness" slider to "Background Opacity".

## How has this been tested?
I ran `npm run dev` to test this.

## Screenshots

<img width="553" alt="background-opacity" src="https://user-images.githubusercontent.com/1377956/42488996-d890549c-844b-11e8-8852-bd3fa15d0d1d.png">


## Types of changes
It's just a label change as dimness isn't a commonly used word.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants