Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace modal's focusOnMount with a optional string providing more options. #7698

Closed
abotteram opened this issue Jul 3, 2018 · 5 comments
Closed
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Feature] UI Components Impacts or related to the UI component system Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@abotteram
Copy link
Contributor

abotteram commented Jul 3, 2018

Is your feature request related to a problem? Please describe.
The Modal component (#6261) has a prop that can be passed to it (focusOnMount) just like the Popover. In the popover this can optionally be a string providing more option where to focus when the component mounts.

As discussed with @aduth this feature should be included in a future iteration.

Describe the solution you'd like
Allow the focusOnMount prop (https://github.com/WordPress/gutenberg/tree/master/packages/components/src/modal#focusonmount) to be either a boolean or a string, following the same pettern and options as the Popover.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

@abotteram abotteram added [Type] Enhancement A suggestion for improvement. [Feature] UI Components Impacts or related to the UI component system labels Jul 3, 2018
@abotteram abotteram mentioned this issue Jul 3, 2018
4 tasks
@abotteram abotteram self-assigned this Jul 3, 2018
@mtias mtias added the [Feature] Extensibility The ability to extend blocks or the editing experience label Jul 19, 2018
@gziolo gziolo added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Aug 1, 2018
@gziolo gziolo added the Needs Dev Ready for, and needs developer efforts label Apr 10, 2019
@draganescu
Copy link
Contributor

Howdy @xyfi I wonder how much of this does #19997 solve? If not completely could we push that to cover this issue completely?

@aduth
Copy link
Member

aduth commented Apr 20, 2020

@draganescu If I recall, the primary goal here was to align Popover and Modal in how this prop works. On a brief glance of #19997, it seems to move in that direction.

@paaljoachim
Copy link
Contributor

This PR might be associated.
#28574

@jordesign
Copy link
Contributor

Just checking in on this request to see if it is still relevant - or if other changes to the modal have resolved it?

@jordesign
Copy link
Contributor

With no further comments in the last month I'm going to close this issue. We can always re-open if needed.

@jordesign jordesign closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Feature] UI Components Impacts or related to the UI component system Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

7 participants