Navigation Link URL setting in Inspector Controls does not allow you to delete last character

[fabiankaegy]

Description

The URL setting in the naviation link blocks settings sidebar does not allow you to remove the final character. So if you for example have an anchor link in there you are not able to delete the # from the URL.

Step-by-step reproduction instructions

1. Go to the site editor
2. Select a navigation menu
3. Add a new custom link menu item
4. Open the settings sidebar
5. Try to remove the URL via the text field in the sidebar

You should be able to remove everything including the last character

Screenshots, screen recording, code snippet

CleanShot.2024-04-15.at.21.48.07.mp4

Environment info

• WordPress 6.5.2
• TT4 Theme

Also:

• WordPress 6.5.2
• Gutenberg Trunk
• TT4 Theme

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[fabiankaegy]

I believe the issue may be this check here:

gutenberg/packages/block-library/src/navigation-link/update-attributes.js

Line 91 in 0469173

...( newUrl && { url: encodeURI( safeDecodeURI( newUrl ) ) } ),

It checks that the URL is truthy via the && check. Which would fail for empty strings.

[Mamaduka]

When I update the logic and allow setting an empty URL value, this is what happens: the URL popover opens and steals the focus.

Screenshot

CleanShot.2024-04-16.at.13.09.52.mp4

[Mamaduka]

It looks like the issue might have been introduced via #49417.

@scruffian, I know it's super old PR, but maybe you can remember why this change was needed.

P.S. The issue affects older versions of WP if we don't meet the timeline for the next minor release. It should be fine to bump this until the next major.

[Mamaduka]

I've yet to test this, but a proposed fix in #61374 might help us fix this issue.

[scruffian]

@scruffian, I know it's super old PR, but maybe you can remember why this change was needed.

Sorry I can't remember!

[getdave]

This is still a problem. When you correct the logic the rich text of the label in the block canvas steals the focus.