Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the delete menu confirm dialogs consistent #59788

Closed
afercia opened this issue Mar 12, 2024 · 2 comments · Fixed by #59825
Closed

Make the delete menu confirm dialogs consistent #59788

afercia opened this issue Mar 12, 2024 · 2 comments · Fixed by #59825
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Feature] Navigation Menus Any issue relating to Navigation Menus Needs Design Feedback Needs general design feedback. [Package] Edit Site /packages/edit-site [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Mar 12, 2024

Description

There's at least two confirm dialog shown when deleting a navigation menu>

  • From the navigation lock inspector > Settings > Advanced > Delete menu
  • From the editor navigaiton panel > Design > Navigation > {menu name} > Actions ellipsis button > Delete

Screenshots:

delete menu from inspector

delete menu from navigation screen

These two confirm dialogs should look very similar but they have differences in terminology, heading name of the buttons.
Under the hood they use different components but that's fine as long as the design and user experiences are as consistent as possible.

At the very least they should:

  • Etiher both have a heading or omit it (better: make it visually hidden).
  • Either both incude the menu name in the heading or omit it.
  • Either both have an X close button or omit it.
  • Use the same casing for 'Navigation menu'.
  • Use the same buttons height.
  • Use the same name for the confirm action: genereally WordPress doesn't use 'Confirm', it rather uses the more specific action name, in this case it should be 'Delete'.

Ideally, they should use the same component.

Step-by-step reproduction instructions

  • Go to the site editor.
  • Select a Navigation block that does have a menu.
  • In the Navigation block inspector, go to the Settings tab, scroll down to 'Advanced', expand it and click 'Delete menu'.
  • Observe the confirmation dialog (actually a Modal component).
  • Go to the navigation screen: Design > Navigation > {menu name} > Actions ellipsis button > Delete
  • Observe the confirmation dialog (actually a ConfirmDialog component).

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Block] Navigation Affects the Navigation Block [Package] Edit Site /packages/edit-site [Feature] Navigation Menus Any issue relating to Navigation Menus labels Mar 12, 2024
@afercia afercia self-assigned this Mar 13, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 13, 2024
@jasmussen
Copy link
Contributor

Good issue. My suggestion would be to go with the second one, always, it's clearer and more actionable.

@afercia
Copy link
Contributor Author

afercia commented Mar 19, 2024

There's already a PR #59825 that aligns the the to dialogs to the second one. A quick review would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] Navigation Menus Any issue relating to Navigation Menus Needs Design Feedback Needs general design feedback. [Package] Edit Site /packages/edit-site [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants