Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data views: Show total count in menu item #57072

Closed
jameskoster opened this issue Dec 14, 2023 · 5 comments · Fixed by #65223
Closed

Data views: Show total count in menu item #57072

jameskoster opened this issue Dec 14, 2023 · 5 comments · Fixed by #65223
Assignees
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Dec 14, 2023

In the Patterns page, each view (pattern category) has an associated count:

Screenshot 2023-12-14 at 16 22 10

It would be nice to bring this UI detail to other views, e.g.:

Screenshot 2023-12-14 at 16 21 32
@jameskoster jameskoster changed the title Show total count in menu item Data views: Show total count in menu item Dec 14, 2023
@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. Needs Dev Ready for, and needs developer efforts [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Dec 14, 2023
@finitelydope
Copy link

Can you explain the issue a bit more?

@jameskoster
Copy link
Contributor Author

Sure. In the Pattern management sidebar each category is represented by a menu item. Inside each menu item is a count indicating how many patterns there are in the category.

I'd like to bring the same count to the DataViewItem component. Then, when you visit page management each view (e.g. "All", "Drafts", "Trash") will communicate how many pages it contains without having to visit it directly.

@jarekmorawski
Copy link
Contributor

In some views it may make sense for menu items to be drilldowns, which means we'll need to display an additional chevron like in the top-level nav. Could we position the count next to the item name to make room for icons, buttons, and other signifiers on the right?

Proposal from another issue: #61437 (comment)

@jameskoster
Copy link
Contributor Author

I suspect we'll get to this some time before we add sub-category support. For now it may make sense to use the current placement, and revisit that detail when it comes to implementing subcategories.

@Souptik2001
Copy link

Hi @jameskoster ,

I have raised a PR for this issue. Can you please review this as per your convinience.

@jorgefilipecosta jorgefilipecosta moved this from 📥 Todo to 🏗️ In Progress in WordPress 6.6 Editor Tasks Jun 12, 2024
@talldan talldan moved this from 🏗️ In Progress to 🏈 Punted to 6.7 in WordPress 6.6 Editor Tasks Jun 24, 2024
@jasmussen jasmussen moved this from Needs Dev to In Dev in Design priorities Aug 6, 2024
@ndiego ndiego moved this to 🏗️ In Progress in WordPress 6.7 Editor Tasks Sep 10, 2024
@github-project-automation github-project-automation bot moved this from In Dev to Done in Design priorities Sep 18, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in WordPress 6.7 Editor Tasks Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Status: Done
Status: 🏈 Punted to 6.7
5 participants