-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Block: Add lightbox support for image aspect ratio #52192
Comments
Regarding the behavior when the lightbox is opened, I think maintaining the aspect ratio specified in the image block settings makes sense. |
I was testing how maintaining the aspect ratio could look like. There are a couple of things to fix but I believe we could get something like this working: Lightbox.Aspect.Ratio.mp4If we agree on this approach, I can take care of submitting a PR with the code. |
That seems a good approach, better than disabling it. have you tried in mobile devices? |
I tested it in the mobile view and it seems to be working. I didn't test it in a real mobile environment. Lightbox.lightbox.-.11.July.2023.mp4 |
Noting that this was resolved in #52292 and works well: CleanShot.2023-10-04.at.12.13.54.mp4 |
What problem does this address?
The lightbox zoom animation is not compatible with the new image aspect ratio controls. We should add that support.
What is your proposed solution?
For now, we should disable the lightbox when an aspect ratio other than the original is defined in the image block settings, but we should also work on adding support.
The text was updated successfully, but these errors were encountered: