Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography: Remove line-height placeholder #51751

Open
hanneslsm opened this issue Jun 21, 2023 · 0 comments
Open

Typography: Remove line-height placeholder #51751

hanneslsm opened this issue Jun 21, 2023 · 0 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@hanneslsm
Copy link

hanneslsm commented Jun 21, 2023

Description

In the typography settings the placeholder that say "1.5" should be removed. It's confusing, especially if the default is not 1.5

Looks like there is already an existing issue #23895 but I'm proposing here simply to remove the placeholder as a quick fix to avoid confusion.

Step-by-step reproduction instructions

  1. Create a theme and set in the theme.json the line height to anything you want, say 1.6
  2. Go to the global styles and get confused why it says 1.5
  3. This is also relevant for headings, and everywhere else where the typography setting exist

Screenshots, screen recording, code snippet

image
image

Environment info

  • WP 6.2.2
  • GB 16.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@kathrynwp kathrynwp added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants