Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add a favicon even if there is no site logo #50860

Closed
andxblink opened this issue May 23, 2023 · 18 comments
Closed

Ability to add a favicon even if there is no site logo #50860

andxblink opened this issue May 23, 2023 · 18 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@andxblink
Copy link

andxblink commented May 23, 2023

Ability missing to add a favicon if there is no "image site logo", but only a "text site logo". Currently, this results in the WordPress default favicon, which my not be preferred.

@hanneslsm
Copy link

You can add a favicon, without having a site logo.
For that, use the customizer by following this link on you website /wp-admin/customize.php?autofocus[section]=title_tagline

However, I can confirm that currently this link can only found on the site logo block settings, which is not ideal.
image

@priethor priethor added [Type] Enhancement A suggestion for improvement. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts. labels May 23, 2023
@andxblink
Copy link
Author

andxblink commented May 23, 2023

Current solution:

  1. Use the site-logo-block to open customizer
  2. add the favicon in customizer
  3. delete the site-logo-block

@paaljoachim
Copy link
Contributor

Thank you for this issue! This is really important missing feature that still has not been added that I know about.
@WordPress/gutenberg-design

@jordesign
Copy link
Contributor

Could we have a setting added under Settings > General for this? And if there is an image already selected - the 'Use as Site Icon' option (in the Site Icon block) defaults to on?

@paaljoachim
Copy link
Contributor

Hey @jordesign
I found this WordPress Trac ticket:
Add an option to configure the site icon in general settings
https://core.trac.wordpress.org/ticket/54370

@jasmussen
Copy link
Contributor

I can't find the issue at the moment, but I think I suggested a Site editor > Settings section for the future, to hold things like these, in an issue about where to store global settings that I vaguely recall @andrewserong creating.

@paaljoachim
Copy link
Contributor

That sounds like a very good idea Joen!
Thank you for sharing!

@jameskoster
Copy link
Contributor

@jasmussen I think that was this issue, which was morphed to narrow scope, and didn't include the site icon setting.

I think we should open a new issue for global settings, or repurpose this one.

@jasmussen
Copy link
Contributor

Ah yes, perfect! This was the comment I made.

@Marc-pi
Copy link

Marc-pi commented Nov 15, 2023

yep, if we want to quit /suppress the old customizer because of the new paradigm (FSE), we neeed indeed a new setting option within the editor
maybe it will be proposed through the new admin works (phase 3) ?

@MaggieCabrera
Copy link
Contributor

There's a valid use case where you don't want your site logo to look like your favicon and vice-versa. You might want them to have different aspect ratios for one

@andrewserong
Copy link
Contributor

Just bringing over a bit of the discussion from #59298. In WP 6.5, the settings page of wp-admin will have an area for adding a site icon (trac ticket: https://core.trac.wordpress.org/ticket/54370). One of the ideas in #59298 was whether it would also be helpful for the site editor to have a dedicated place for updating the site icon so that folks don't need to navigate out of the site editor in order to make updates? This is probably less urgent now that we'll be able to link users to the settings page instead of into the customizer (the issue to update the link is here: #59382).

I'd be curious to hear what folks think, if the new area in the settings page for updating the icon is enough for now.

@jameskoster
Copy link
Contributor

I'd agree it's less urgent now. I'd be tempted to hold off adding the setting to the site editor until we have a slightly clearer overall picture of the ongoing Admin design work.

@Sam-Xronn
Copy link
Contributor

@andxblink I feel like this issue can be closed now? The WP 6.5 feature has covered off this issue?

@richtabor
Copy link
Member

Makes sense to me.

@wdburgdorf
Copy link

How is this covered? I still see no option to set the favicon. Settings ("Style Book") only has the site logo, no favicon. (WP 6.6.2)

@hanneslsm
Copy link

How is this covered? I still see no option to set the favicon. Settings ("Style Book") only has the site logo, no favicon. (WP 6.6.2)

You can now change the favicon / site icon in the general settings.
https://core.trac.wordpress.org/ticket/54370
I guess this resolves this issue and can be closed.

@jasmussen
Copy link
Contributor

Thanks for responding that. Closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests