Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Parts link leads to a Site Editor with just a loading icon in hybrid theme. #48391

Closed
aurooba opened this issue Feb 23, 2023 · 4 comments
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@aurooba
Copy link
Member

aurooba commented Feb 23, 2023

Description

I've got a hybrid (non-block) theme that has Template Parts enabled. When you go to Appearance > Template Parts, you get a loading screen or an error, instead of the expected Template Parts screen.

Step-by-step reproduction instructions

  1. on 6.2-beta3-55418 version of WordPress
  2. Install a regular theme that has Template Parts support enabled and at least 1 Template Part
  3. Go to Appearance > Template Parts
  4. See the loading screen
  5. Refresh the page, get the error: The theme you are currently using is not compatible with the Site Editor.

Screenshots, screen recording, code snippet

Site Editor with the sidebar but a loading screen instead of the expected Template Parts screen

If you refresh the page, you get the following error: The theme you are currently using is not compatible with the Site Editor.

Environment info

WordPress: 6.2-beta3-55418 version of WordPress
Gutenberg: Tested with Gutenberg and without Gutenberg
Browser: Google Chrome

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@aurooba aurooba changed the title Template Parts Screen just shows a loading icon Template Parts Screen just shows a loading icon in hybrid theme. Feb 23, 2023
@aurooba aurooba changed the title Template Parts Screen just shows a loading icon in hybrid theme. Template Parts link leads to a Site Editor with just a loading icon in hybrid theme. Feb 23, 2023
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Block] Template Part Affects the Template Parts Block labels Feb 24, 2023
@annezazu annezazu moved this to ❓ Triage in WordPress 6.2 Editor Tasks Feb 24, 2023
@annezazu annezazu moved this from ❓ Triage to 📥 Todo in WordPress 6.2 Editor Tasks Feb 24, 2023
@annezazu annezazu added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Feb 24, 2023
@ndiego
Copy link
Member

ndiego commented Feb 24, 2023

@aurooba does it look like #48292 could be a similar issue?

@aurooba
Copy link
Member Author

aurooba commented Feb 24, 2023

@ndiego Ooh yes. This is definitely connected. But in this case, we wouldn't want the front page to load anyway, we want it to take us directly to the Template Parts page. Should I add my feedback/notes to #48292 and close this here?

@ndiego
Copy link
Member

ndiego commented Feb 24, 2023

Let's leave this open until we are 100% sure it's the same root issue. If you have time to add feedback on the other issue, that would be awesome. 🙏

@Mamaduka
Copy link
Member

Fixed via #48343 and will be included in the next beta. We also have an E2E test for this feature, so we should catch similar regressions early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

No branches or pull requests

4 participants