Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template Part semantic areas are no longer recognised #45935

Closed
jameskoster opened this issue Nov 21, 2022 · 1 comment · Fixed by #49500
Closed

Template Part semantic areas are no longer recognised #45935

jameskoster opened this issue Nov 21, 2022 · 1 comment · Fixed by #49500
Assignees
@talldan
Labels
[Block] Template Part Affects the Template Parts Block Needs Dev Ready for, and needs developer efforts [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Nov 21, 2022 •
edited
Loading

Description

Screenshot 2022-11-21 at 09 15 37

In the screenshot above note that the general template part icon is used for the selected Header, and the Footer in list view. Additionally the the block name in the Inspector is incorrect (may be related to #42154).

Step-by-step reproduction instructions

  1. Open the site editor
  2. Select a header or footer template part
  3. Ensure it has the 'header' or 'footer' semantic area set (check the Advanced panel in the Inspector)
  4. Observe the icon, and block name in the Inspector

Environment info

Latest trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Block] Template Part Affects the Template Parts Block labels Nov 21, 2022
@jameskoster jameskoster added [Priority] High Used to indicate top priority items that need quick attention [Type] Regression Related to a regression in the latest release labels Dec 2, 2022
@annezazu
Copy link
Contributor

If I'm following this correctly, I can replicate with 6.2 RC 2:

Screen Shot 2023-03-20 at 3 24 08 PM

@annezazu annezazu moved this to 💻 Needs development in Gutenberg Phase 2: Customization Mar 22, 2023
@annezazu annezazu added the Needs Dev Ready for, and needs developer efforts label Mar 22, 2023
@talldan talldan mentioned this issue Mar 31, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 31, 2023
@github-project-automation github-project-automation bot moved this from 💻 Needs development to ✅ Done in Gutenberg Phase 2: Customization May 2, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talldan talldan

Labels
[Block] Template Part Affects the Template Parts Block Needs Dev Ready for, and needs developer efforts [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
Gutenberg Phase 2: Customization
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix template part area variation matching WordPress/gutenberg
4 participants
@talldan @jameskoster @annezazu @priethor