Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming or removing "Areas" in dropdown #45181

Closed
annezazu opened this issue Oct 21, 2022 · 10 comments
Closed

Consider renaming or removing "Areas" in dropdown #45181

annezazu opened this issue Oct 21, 2022 · 10 comments
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

Currently, the dropdown when in the site editor shows a section titled "areas" when referring to template parts. This is a bit confusing as "areas" is not a well defined term and it's referring to template parts:

image (27)

I understand that each template part sets an assigned "area" and carries semantic meaning but I'm a bit confused around the naming of "areas" in the dropdown.

What is your proposed solution?

Rename "areas" to something like:

cc @jameskoster for context here since afaik you've worked on that dropdown!

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. [Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Oct 21, 2022
@talldan
Copy link
Contributor

talldan commented Oct 21, 2022

Naming it 'Template Parts' might lead to confusion around why all template parts aren't shown (only root-level template parts are). It could also be 'Template Part Areas', but that feels a bit verbose.

If it is changed it'd be good to also consider the other parts of the UI that use this term:

Advanced block inspector section:
Screen Shot 2022-10-21 at 11 34 24 am

The modal shown when converting blocks to a template part:
Screen Shot 2022-10-21 at 11 35 43 am

As a side note, I'd be interested to know how many users find that dropdown in the top bar useful. I personally always forget that it exists.

@jameskoster
Copy link
Contributor

The purpose of the feature is to highlight template parts within the document that have semantic meaning. So we should probably stay away from more generic labels like Sections or Synced blocks.

As a side note, I'd be interested to know how many users find that dropdown in the top bar useful

I often use the dropdown to clear customizations, but never to navigate template parts. List View feels like a more intuitive destination for this kind of activity. Obviously that's subjective, but if the general consensus is that this feature is never used, perhaps we could consider removing it?

@annezazu
Copy link
Contributor Author

Obviously that's subjective, but if the general consensus is that this feature is never used, perhaps we could consider removing it?

I'd be curious if it would be missed too :)

@MadtownLems
Copy link

We're using a classic theme and are excited to add Template Parts now that 6.1 is here. In our case, does this dropdown even do anything at all? We certainly can't figure out what it's supposed to be accomplishing and is just confusing to our users.

@annezazu
Copy link
Contributor Author

@MadtownLems this dropdown when looking solely at template parts, would allow you to change the semantic meaning of the template part (general, footer, header). I can totally see how this is just confusing to folks!

@MadtownLems
Copy link

@annezazu Unless I'm misunderstanding something (totally possible!), this dropdown has absolutely no impact or bearing in the case of traditional themes that make use of Template Parts, correct?

All of our Template Parts are registered by our theme. Giving them a new "Area" seems to have no effect, as far as I can tell. (And even if it did, it seems like users shouldn't be able to re-assign Template Parts to a different area)

@annezazu
Copy link
Contributor Author

That's correct ^ @Mamaduka -- since you implemented the template parts in classic themes, I wonder if there's a way, for now, to remove this dropdown from that experience. As @MadtownLems points out, it doesn't really make much sense to have and I wouldn't want to wait on this larger decision about the dropdown to be made in order to move this forward.

@Mamaduka
Copy link
Member

That makes sense, I will create PR shortly for hiding the dropdown.

@annezazu
Copy link
Contributor Author

annezazu commented Jan 3, 2023

Noting more feedback to consider as a part of the nineteenth call for testing:

The title area at the top makes no sense to me. Why can’t I select between templates there? Why when I select a header or footer in the title area I can’t get out of the header or footer in the title area, but from the list area on the left?

Curious how/if this can evolve as browse mode does as well as it does seem to be less and less relied upon.

@annezazu annezazu changed the title Consider renaming "Areas" in dropdown Consider renaming or removing "Areas" in dropdown Jan 16, 2023
@Mamaduka
Copy link
Member

This was resolved via #48490.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants