Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayoutPanel: Switch to using the ToolsPanel #44560

Open
andrewserong opened this issue Sep 29, 2022 · 2 comments
Open

LayoutPanel: Switch to using the ToolsPanel #44560

andrewserong opened this issue Sep 29, 2022 · 2 comments
Assignees
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Layout Layout block support, its UI controls, and style output. [Type] Enhancement A suggestion for improvement.

Comments

@andrewserong
Copy link
Contributor

andrewserong commented Sep 29, 2022

This issue is to propose / track progress on switching the LayoutPanel used by the layout block support over to using the ToolsPanel instead of PanelBody.

As new controls are added to the LayoutPanel, the area of the layout panel within the inspector controls increases, and there will likely be many blocks for which new controls should be hidden by default. As with the Typography (#33744) and Dimensions (#32392) panels previously, switching over to the ToolsPanel will allow blocks to define which layout controls to display by default.

For reference, here are screenshots of the Typography panel next to the Layout panel:

The group block's Typography panel
(only font size is displayed by default)
Layout panel (all eligible controls displayed)
image image

It's been mentioned a few times on other Github issues (e.g. recently by @jasmussen here: #35849 (comment)), so I thought this issue could be a useful place for looking at that task in isolation.

There are related earlier discussions about overhauling the panel and what gets included in it (e.g. #34698), however for the purposes of this issue, the task is to keep all the controls as-is for the moment, but refactor to the ToolsPanel so that in separate tasks, the decision of what goes where can be made.

@andrewserong andrewserong added [Type] Enhancement A suggestion for improvement. [Feature] Layout Layout block support, its UI controls, and style output. labels Sep 29, 2022
@andrewserong andrewserong added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Sep 29, 2022
@jasmussen
Copy link
Contributor

Great ticket, thank you. One addition, when we move this to become a tools panel, we should hide by default the option to allow wrapping:

Screenshot 2022-09-29 at 09 46 37

As a separate sidenote on the components (cc @ciampo), the justification icons should all be gray-900 (almost black). This is my bad, I included them in gray in a mockup, apologies. This is only for icons, to note, non active text items in a segmented control should still be dark gray.

@richtabor
Copy link
Member

We should certainly do this. It allows us to continue expanding layout controls without expanding layout complexity. Related to #62895 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Layout Layout block support, its UI controls, and style output. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants