Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacer block - Crashes when changing the height value using the text input #40045

Closed
geriux opened this issue Apr 5, 2022 · 2 comments · Fixed by #40053 or wordpress-mobile/WordPress-Android#16285
Assignees
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended

Comments

@geriux
Copy link
Member

geriux commented Apr 5, 2022

Description

Changing the height value of the Spacer block crashes the app.

Step-by-step reproduction instructions

  1. Open the app
  2. Create a post or page
  3. Add a Spacer block
  4. Open the block's settings
  5. Change the height value using the keyboard

Expected behaviour

You should be able to change the value using the keyboard

Actual behaviour

The app crashes when trying to edit the value

Screenshots or screen recording (optional)

WordPress information

  • WordPress version: Latest version
  • Gutenberg version: Latest in trunk
  • Are all plugins except Gutenberg deactivated? No
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes

Device information

  • Device: iPhone 12 Pro
  • Operating system: 15.3
  • WordPress app version: 19.6
@geriux geriux added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Apr 5, 2022
@fluiddot
Copy link
Contributor

fluiddot commented Apr 5, 2022

I've just followed the reproduction instructions with the WP-Android beta version 19.6-rc-1 and managed to reproduce the crash.

Here is the Sentry event related to the crash:
https://sentry.io/share/issue/f69cf2cbf05f4064a66748d515cab007/

@fluiddot fluiddot self-assigned this Apr 5, 2022
@fluiddot
Copy link
Contributor

fluiddot commented Apr 5, 2022

Looks like the issue was introduced in #39577. The import of MIN_SPACER_SIZE constant is pointing to the native version of the edit file (i.e. edit.native.js), however, the constant is defined in the web version (edit.js). Simply updating the import statement should address the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
2 participants