Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles > Add Button Color to Elements #39473

Closed
bradhogan opened this issue Mar 15, 2022 · 6 comments
Closed

Styles > Add Button Color to Elements #39473

bradhogan opened this issue Mar 15, 2022 · 6 comments
Labels
[Block] Buttons Affects the Buttons Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json

Comments

@bradhogan
Copy link

What problem does this address?

Links are generally not the same as site button colors.

What is your proposed solution?

Add two sections to the Styles > Elements component for Button Text & Button Background.

@paaljoachim paaljoachim added [Block] Buttons Affects the Buttons Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json and removed Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Mar 30, 2022
@paaljoachim
Copy link
Contributor

Hey @bradley2083 Brad

Here is an example where I selected the individual button. Color options: Text and Background.

Screenshot 2022-03-30 at 17 32 36

Is there something else you are thinking about?

@bradhogan
Copy link
Author

@paaljoachim Correct. I'm proposing a global button color that can be set in the global Styles section (still leaving the individual button customization as-is). Right now, there are only global styles for Background, Text and Links (I think Buttons and Headings - H1,H2,etc. should be added to this list).
Screen Shot 2022-03-30 at 9 56 11 AM

@paaljoachim paaljoachim added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Mar 31, 2022
@paaljoachim
Copy link
Contributor

That is a very good idea @bradley2083 Bradley!
@jorgefilipecosta I believe this is an issue you might be able to take a closer look at.

@annezazu
Copy link
Contributor

Wanted to note that for this would likely be a big hit with theme authors considering these previous theme design survey results in the FSE Outreach program. It reflects how the button block was a top item that folks customized with per block settings or styles in theme.json.

@scruffian
Copy link
Contributor

I think this was achieved in #40260

@paaljoachim
Copy link
Contributor

paaljoachim commented Sep 7, 2022

Thanks for seeing this Ben @scruffian
Here is the result in Twenty Twenty Two with the Gutenberg plugin activated.

Screenshot 2022-09-07 at 16 58 30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Projects
None yet
Development

No branches or pull requests

4 participants