-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a confirmation modal when clearing the customizations on a template #39124
Comments
I agree that the impact might be big and it could be good to have an extra confirmation step.. --cc @jameskoster @jasmussen @kjellr |
Worth noting that when you revert whilst editing the document there is an undo affordance: revert.mp4We used the undo pattern here for a couple of reasons:
Obviously the second point doesn't apply on the template list view, and the first point holds less water generally since we removed the ability to retrieve templates from the trash. All that to say: I think it's probably okay to install the confirmation dialog on template list, but we should acknowledge that the revert flow would then differ based on the view. Is it risky to make a high impact action feel unpredictable? If we wanted to make reverting consistent, another option might be to make the button itself feel more like a "danger zone" (IE make the link red, to match Trash links), and add the undo action to the Snackbar on list view. |
I have created a new issue for the missing confirmation when deleting a template. I think most of the user do not distinguish between "clear" and "delete". They will lose all their work, no matter what they click, so a similar/same implementation should be used here for both. @jameskoster re while editing: I think a confirmation step should also be included while editing, not only for consistency but also for good UX. |
Another random thought: If a modal is implemented, the "Export Theme" function could be linked, so that the user can download a snapshot of the theme before clearing the customisations/ deleting a template. Example wording, this must surely be refined…
|
What problem does this address?
The impact on clearing a customization on a template or template part can be huge, especially when you put a lot work in building your templates with the FSE.
However, all the work can be deleted with just one or two thoughtless clicks on the menu:
What is your proposed solution?
Add a modal where the user has to confirm that all their work will be deleted. Maybe some additional info text to make clear what impact the clearing exactly has.
The text was updated successfully, but these errors were encountered: