Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update userCanCreatePages to canUserCreatePages for consistency #35253

Open
getdave opened this issue Sep 30, 2021 · 0 comments
Open

Update userCanCreatePages to canUserCreatePages for consistency #35253

getdave opened this issue Sep 30, 2021 · 0 comments
Assignees
@getdave @kevin940726
Labels
[Type] Code Quality Issues or PRs that relate to code quality

Comments

@getdave
Copy link
Contributor

getdave commented Sep 30, 2021 •
edited
Loading

IN #35083 (comment)_ @kevin940726 suggested we should rename the userCanCreatePages variable to canUserCreatePages. This is utilised in both:

  • Nav block
  • Inline within the format UI.

...to determine whether a user can create pages.

We should update it for consistency.

I agree other than the fact that the Nav block already uses the userCanCreatePages pattern. Happy to raise a follow up to update this though as I agree your suggestion might be preferable.

Originally posted by @getdave in #35083 (comment)
@getdave getdave added the [Type] Code Quality Issues or PRs that relate to code quality label Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getdave getdave

@kevin940726 kevin940726

Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@getdave @kevin940726