Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use block icons on the Global Styles "Block Types" interface #34942

Closed
richtabor opened this issue Sep 19, 2021 · 4 comments
Closed

Use block icons on the Global Styles "Block Types" interface #34942

richtabor opened this issue Sep 19, 2021 · 4 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback.

Comments

@richtabor
Copy link
Member

What problem does this address?

We leverage block icons everywhere, but in the current Global Styles "Block Types" panel, we're not.

Screen Shot 2021-09-19 at 7 14 27 PM

What is your proposed solution?

Consider adding the block icons to the left of the labels for each block.
Screen Shot 2021-09-19 at 7 15 11 PM

@richtabor richtabor added Needs Design Needs design efforts. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Sep 19, 2021
@karmatosed
Copy link
Member

+1 to use these if we are showing the blocks we should also show block icons. However, I also ponder if this screen is having some work done on it as part of the new sidebar work so @jasmussen I wonder if you have some context there?

@jasmussen
Copy link
Contributor

I've been watching along the sidelines of #34574 how the inspector layout has been evolving since the initial version that landed as part of #18667. One of the things emerging so far appears to be the ItemGroup panel, which could for example group a stack of color swatches together, as well as the ability for the interface to slide as you drill down into an item. In absence of a good mockup exploring it, I'm not sure that ItemGroup would be a good interface for styling by block type, or whether we might want something that was closer along the lines of the list view from the slash command or the transform dialog. In all cases, icons probably do make sense there, and is definitely worth exploring in mockup form.

@karmatosed
Copy link
Member

The sidebar is having some iterations but potentially right now using what is in main here is a rapid mock:

2021-10-02 at 00 40

@karmatosed karmatosed added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Oct 1, 2021
@mtias
Copy link
Member

mtias commented May 23, 2022

This was completed a little while ago.

@mtias mtias closed this as completed May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

4 participants