Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent text case when displaying template part names #34737

Closed
jameskoster opened this issue Sep 10, 2021 · 5 comments · Fixed by #42221
Closed

Inconsistent text case when displaying template part names #34737

jameskoster opened this issue Sep 10, 2021 · 5 comments · Fixed by #42221
Assignees
@Mamaduka
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

On my site I have a template part named "header". In the top bar, the block toolbar, and the Inspector this is capitalised and appears as "Header", but in the navigation sidebar it is not:

Screenshot 2021-09-10 at 11 54 08

Let's decide on the correct implementation and apply that consistently.
@jameskoster jameskoster added [Feature] Full Site Editing [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Sep 10, 2021
@carolinan
Copy link
Contributor

I feel like the name that the user entered during the template creation should be displayed, and the capitalization should not be changed.

@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended Needs Dev Ready for, and needs developer efforts labels May 6, 2022
@jameskoster jameskoster added the [Block] Template Part Affects the Template Parts Block label May 30, 2022
@jameskoster
Copy link
Contributor Author

This is also an issue in the template part ellipsis menu:

Screenshot 2022-05-30 at 16 40 22

  • Edit header
  • Remove Header

@jameskoster jameskoster mentioned this issue May 30, 2022
Closed
43 tasks
@carolinan
Copy link
Contributor

carolinan commented Jul 7, 2022 •
edited
Loading

I am not able to reproduce this any more (using Gutenberg trunk).
The only part that does not display the template part title as I entered it, is the inspector.
And an issue for that was created here: #42154.

@Mamaduka Mamaduka mentioned this issue Jul 7, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 7, 2022
@Mamaduka Mamaduka removed the Needs Dev Ready for, and needs developer efforts label Jul 7, 2022
@jameskoster
Copy link
Contributor Author

I'm still seeing the slug being used in the ellipsis menu:

Screenshot 2022-07-07 at 11 56 25

But it looks like that will be fixed in 42221.

@Mamaduka
Copy link
Member

Mamaduka commented Jul 7, 2022

@jameskoster, I made sure to use correct casing when swapped actions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mamaduka Mamaduka

Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Template Part: Swap block action places WordPress/gutenberg
3 participants
@Mamaduka @jameskoster @carolinan