Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add width to setting and styles #31037

Closed
oandregal opened this issue Apr 21, 2021 · 1 comment
Closed

Add width to setting and styles #31037

oandregal opened this issue Apr 21, 2021 · 1 comment
Labels
[Block] Site Logo Affects the Site Logo Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@oandregal
Copy link
Member

oandregal commented Apr 21, 2021

Part of #20331

There's a use case for themes to be able to set the width of the site logo block. See #30907 (comment)

This value is used both as a setting for the block and a style. For themes to set these values via theme.json we need to:

  • add a width setting blocks can use via useEditorFeature
  • add a width style that will be appended to the stylesheet generated by global styles

As for the group for these values to live, it sounds like spacing could be a fine fit.

@oandregal oandregal mentioned this issue Apr 21, 2021
82 tasks
@oandregal oandregal added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Apr 21, 2021
@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Block] Site Logo Affects the Site Logo Block labels Aug 17, 2023
@oandregal
Copy link
Member Author

Closing this one as it hasn't seen any movement in +3 years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Logo Affects the Site Logo Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants