Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for screen size/responsive styling #29052

Closed
annezazu opened this issue Feb 16, 2021 · 5 comments
Closed

Allow for screen size/responsive styling #29052

annezazu opened this issue Feb 16, 2021 · 5 comments
Labels
[Feature] Block settings menu The block settings screen [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

Currently, there's not a way to style items based on screen size. For example, if I want to hide an image when my site is viewed on mobile, I have to use custom CSS. This is a common use case for many site builders and came up as a question as part of this FSE program effort. Currently, we only allow for previewing based on the screen size:

preview.devices.mov

I couldn't find a similar issue mentioned already so, if this has already been discussed somewhere, apologies!

What is your proposed solution?

Enable device specific styling/settings in block settings. Here's an example from Elementor: https://elementor.com/help/mobile-editing/

@annezazu annezazu added General Interface Parts of the UI which don't fall neatly under other labels. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Block settings menu The block settings screen Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement. labels Feb 16, 2021
@overclokk
Copy link

This could be usefull but it should be a theme choices with for example add_theme_support(), and so I can select to have 3 or 4 breaking point (Bootstrap CSS has 4).

@leph83
Copy link

leph83 commented May 6, 2021

When coding the header in my custom theme, I prefer to use flexbox or display grid instead of creating columns. That way I don't need a breakpoint, because the content will just wrap, if there's not enough space. Also no need to adjust the column width depending on the amount of navigation items.
But yeah, you still need at least one breakpoint to switch from mobile nav to desktop nav.

As a user I would prefer to create two headers. One for mobile and one for desktop with the possibility to define the breakpoint in the editor.

@kjellr
Copy link
Contributor

kjellr commented Jul 7, 2021

Related Issues:
#19909
#13363

(This may actually be a duplicate of one of those?)

@annezazu
Copy link
Contributor Author

annezazu commented Jul 7, 2021

Amazing - thanks for connecting these dots. I tried hard to find related issues when I originally posted this but came up empty at the time! Going to close this out and add a few more labels to the other issues.

@annezazu annezazu closed this as completed Jul 7, 2021
@sinanisler
Copy link

related to this issue, lets continue here
#55619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block settings menu The block settings screen [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants