Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Icons: Move color options to block toolbar #28314

Closed
jasmussen opened this issue Jan 19, 2021 · 3 comments
Closed

Social Icons: Move color options to block toolbar #28314

jasmussen opened this issue Jan 19, 2021 · 3 comments
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

In #28084, social icons landed the ability to change foreground and background colors of icons.

This happens in the sidebar, but it's such a useful action, it should happen in the toolbar. Like this, perhaps:

105010409-f67eaf80-5a3b-11eb-8a61-7cc55e4df323

This mockup is inspired by this original design, but expanded with a little influence from #27331.

@carolinan
Copy link
Contributor

Is this still something we want to implement?

@jasmussen
Copy link
Contributor Author

The design is a bit out of date, but in my mind it still makes sense to do this, including for other blocks where the color plays a prominent role, such as Cover.

@jasmussen
Copy link
Contributor Author

I'll close this for now. As out of date as the visuals are, let's revisit separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants