Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the concepts of block styles and Global Styles/theme.json #27476

Closed
jorgefilipecosta opened this issue Dec 3, 2020 · 1 comment
Closed
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Discussion For issues that are high-level and not yet ready to implement.

Comments

@jorgefilipecosta
Copy link
Member

Currently, the block styles are just a class that can apply any style using CSS.
Global Styles/theme.json allows users and themes to apply styles to blocks and globally.

There is no connection between the two systems.

@mtias suggested the two systems should be connected. For example, allow the user to register the style changes made as a block style variation. Allow themes to create block styles using theme.json etc.
In fact, the typographic presets shown on #27331 could be just a block style that is only changing typographic attributes.
We should not implement any additional presets before this exploration is done.

Previously in a conversation with @youknowriad, it also seemed that block styles could be the semantic nesting element we need. E.g., If we allow controlling the styles of blocks nested inside a specific block style. Controlling the style of paragraphs inside a template area would be a matter of controlling the designs of paragraphs inside a specific block style and applying that style to a template part.

We are not totally sure about what mixing the two concepts will bring but it seems something we should explore right after having the design ready #27473.

@talldan talldan added [Feature] Theme Style Variations Related to style variations provided by block themes Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Discussion For issues that are high-level and not yet ready to implement. labels Dec 7, 2020
@youknowriad
Copy link
Contributor

While not solved fully, we're in a better position today. These two things share the same UI, same "style" object (to a certain level because of backwards compatibility), we can define block style variation using theme.json config.

I think what's left is probably A unified style generation engine but that's tracked separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Discussion For issues that are high-level and not yet ready to implement.
Projects
None yet
Development

No branches or pull requests

3 participants