Document Actions: Block Toolbar overlaps Document Titles

[jeyip]

Describe the bug
When scrolling through the block editor, if a block toolbar is displayed, it can overlap the document actions labels.

To reproduce
Steps to reproduce the behavior:

1. Set up the site editor locally
2. Navigate to the site editor
3. Hover over a sibling inserter
4. Scroll down through the editor until the block toolbar would overlap the document actions labels
5. Verify that there is no visual overlap

Expected behavior
When scrolling through the block editor, the block toolbar does not overlap document actions labels.

Screenshots

[Addison-Stavlo]

I noticed the block-popover has z-index of 31, while the header in the interface skeleton has z-index of 30. It seems to be noted as intended to be above the header:

gutenberg/packages/base-styles/_z-index.scss

Lines 91 to 92 in c2ea1b2

	// Above the block list and the header.
	".block-editor-block-list__block-popover": 31,

However, it does not behave this way in the post editor. I tried to dig around a bit but am unsure why it behaves differently in the other editor. 🤔

[jeyip]

@shaunandrews

I see that you introduced the code Addie mentioned above. Link to the commit and the pr. Do you happen to remember why we wanted the popover above the block list and the header?

I'm making my way through the PR (it's pretty long) and, I might be missing something, but I can't seem to find more information about the reasoning 😅

[shaunandrews]

Mainly so the parent selector button would be visible.

[david-szabo97]

This seems to be resolved by now:

Screen.Recording.2021-02-25.at.14.52.40.mov

[shaunandrews]

Can confirm; This has been fixed.