Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget Editor: Drop placeholder should appear below any existing blocks/widgets #25708

Closed
mapk opened this issue Sep 29, 2020 · 0 comments · Fixed by #25727
Closed

Widget Editor: Drop placeholder should appear below any existing blocks/widgets #25708

mapk opened this issue Sep 29, 2020 · 0 comments · Fixed by #25727
Assignees
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@mapk
Copy link
Contributor

mapk commented Sep 29, 2020

Current in #25681, when hovering over a block in the Inserter, the drop placeholder (blue line) appears at the top of the first widget area when nothing is selected. It appears at the top even when there are existing blocks/widgets already in that area.

Screen Shot 2020-09-29 at 8 05 08 AM

I'd like this to mimic the behavior in the post editor. This means that the blue line should appear below any existing blocks/widgets.

If the area has so many blocks in it that it extends below the screen, it should follow the pattern found in the post editor which is to not scroll to show the placeholder, but instead drop the block in the area and then move that area into view with the block selected.

cc @adamziel @draganescu

@mapk mapk added Needs Dev Ready for, and needs developer efforts [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Sep 29, 2020
@mapk mapk added this to the 5.6 milestone Sep 29, 2020
@mapk mapk removed this from the 5.6 milestone Sep 29, 2020
@kevin940726 kevin940726 self-assigned this Sep 30, 2020
@kevin940726 kevin940726 added the [Type] Bug An existing feature does not function as intended label Sep 30, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants