Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken plugins with color palette change #25652

Closed
ajlende opened this issue Sep 25, 2020 · 1 comment
Closed

Broken plugins with color palette change #25652

ajlende opened this issue Sep 25, 2020 · 1 comment
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability

Comments

@ajlende
Copy link
Contributor

ajlende commented Sep 25, 2020

The changes introduced in #25419 break existing plugins that use the color palette.

Two of the plugins that I maintain, Starscape and Waves, both break with this change.

I see that it was marked as a breaking change, but if possible it would be nice to maintain that backwards compatibility so that we're not breaking existing plugins.

cc @jorgefilipecosta @youknowriad
@ajlende ajlende added the Backwards Compatibility Issues or PRs that impact backwards compatability label Sep 25, 2020
@ajlende ajlende mentioned this issue Sep 28, 2020
Merged
@oandregal oandregal mentioned this issue Oct 9, 2020
Merged
@oandregal
Copy link
Member

oandregal commented Oct 9, 2020 •
edited
Loading

I think #25738 fixes this one. Please, be welcome to re-open if it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oandregal @ajlende