Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Some buttons don't show their tooltips any longer #25380

Closed
afercia opened this issue Sep 16, 2020 · 0 comments · Fixed by #25391
Closed

Regression: Some buttons don't show their tooltips any longer #25380

afercia opened this issue Sep 16, 2020 · 0 comments · Fixed by #25391
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@afercia
Copy link
Contributor

afercia commented Sep 16, 2020

Describe the bug

This seems to be a regression in the plugin, current version is 9.0.0.

Worth reminding that tooltips are important for accessibility because:

  • icons don't have a universal meaning (different cultural backgrounds, cognitive impairments, etc,)
  • tooltips are the only way to visually expose the name of icon-only controls to users of assistive technologies, more importantly to users of speech recognition software

To reproduce

  • first: test without the Gutenberg plugin activated
  • edit a post and select a Paragraph block
  • the block toolbar appears
  • hover (or tab to) all the toolbar buttons and observe they all display their tooltip
  • activate the Gutenberg plugin
  • repeat the steps above
  • observe not all buttons display their tooltips

Here's some buttons that don't show tooltips any longer. This list doesn't pretend to be exhaustive, it's just to point to some clear examples and to highlight it doesn't happen only in the editor:

Paragraph block toolbar:

  • Change block type or style
  • Change text alignment
  • More rich text controls
  • More options

On the new Navigation page:

  • More rich text controls
  • More options

On Full Site Editing with a template part selected:

  • Change block type or style
  • Change alignment
  • More options

Git bisect told me the offending commit is e703aee which is #24304.
Cc @tellthemachines

Expected behavior
All the icon-only buttons to display their tooltip.

Editor version (please complete the following information):

  • WordPress version: 5.6 trunk
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? plugin
  • If the Gutenberg plugin is installed, which version is it? 9.0.0
@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Regression Related to a regression in the latest release labels Sep 16, 2020
@tellthemachines tellthemachines self-assigned this Sep 17, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants