Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the new Navigation editor to the world #24683

Closed
3 tasks
draganescu opened this issue Aug 20, 2020 · 15 comments
Closed
3 tasks

Introduce the new Navigation editor to the world #24683

draganescu opened this issue Aug 20, 2020 · 15 comments

Comments

@draganescu
Copy link
Contributor

draganescu commented Aug 20, 2020

Introduction

Currently as part of Gutenberg's phase 2 process there is an effort put into upgrading the current menus screen to a block based editor. With the latest progress in #24503 the project is in an architecturally stable point.

It is a good moment to remove the experimental cloak and have it available for a larger user base via the Gutenberg plugin. Issues such as ensuring the best possible backwards compatibility ( #23739 ) need more participation. Also the UI and UX explorations will advance smoother with more feedback.

Then, in the near future, after the Navigation editor is out of being just an experiment, it becomes beta software and the project's focus will be on fixing it, including the default workflow it will offer, and therefore move on with replacing the current screens. Also, aside from revamping the UX of making menus, this project allows users to bring blocks into their menus and that requires themes to opt in. Testing this important feature via the Gutenberg plugin sooner rather than later is essential for it to work properly.

Actions

  • Remove the experimental flags that hide the Navigation editor
  • Check the filter to opt out works as expected
  • Release the Navigation editor as a default Appearance > Menus link in Gutenberg
@draganescu draganescu added [Type] Discussion For issues that are high-level and not yet ready to implement. [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues Needs Design Feedback Needs general design feedback. labels Aug 20, 2020
@StaggerLeee
Copy link

Are there any remote ideas to turn it to mega menus ? As expansion of it.

@aristath
Copy link
Member

@StaggerLeee in time it will be possible to use some more blocks inside menus so it will be possible to build what most people refer to as "mega menu". But that is not the current focus, or the point of this ticket 👍

@noisysocks
Copy link
Member

Before a developer can pick up this issue, we need to know which design changes are required for us to be happy with soft launching the Navigation screen. Do you have a list, @shaunandrews?

@shaunandrews
Copy link
Contributor

@noisysocks I outlined my thoughts over here: #24875

@noisysocks
Copy link
Member

noisysocks commented Aug 28, 2020

Thanks @shaunandrews!

So, to summarise the status here, we're blocked on #24875 and #24760. Once those two overview issues are addressed we can remove the experimental flag.

@noisysocks noisysocks added [Status] Blocked Used to indicate that a current effort isn't able to move forward and removed Needs Design Feedback Needs general design feedback. labels Aug 28, 2020
@noisysocks noisysocks added [Feature] Navigation Screen and removed [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues [Type] Discussion For issues that are high-level and not yet ready to implement. labels Aug 28, 2020
@sirreal
Copy link
Member

sirreal commented Oct 15, 2020

Has this issue been superseded by another or should we point to another place for tracking? The information here is stale to the best of my knowledge.

@noisysocks
Copy link
Member

Hey @sirreal. The best way to track the status of this project is by checking the project board. Currently the contributors that were working full time on this project have hit pause and are focusing instead on Widgets. It's likely we'll come back to this for WordPress 5.7.

@draganescu
Copy link
Contributor Author

Moving this from blocked as both blocking issues are now closed.

@talldan talldan removed the [Status] Blocked Used to indicate that a current effort isn't able to move forward label Apr 20, 2021
@getdave
Copy link
Contributor

getdave commented Jun 28, 2021

As we're not yet ready to do this I've moved to the "Medium" priority section of the board. This reduces visual "clutter" and helps clear up what is Highest Priority,

@draganescu
Copy link
Contributor Author

Wow accidentally made an issue of a task here :D

@skorasaurus
Copy link
Member

Wow accidentally made an issue of a task here :D

Might be a result of the changes to Github issues some of which have already been released? :)

@superbmario
Copy link

Regarding "Check the filter to opt out works as expected" - what will the filter be named? I'd like to start adding that to sites I know won't be needing this feature to avoid possible issues. Knowing the name in advance will be super useful for people like me, so if it not yet determined then I'd like to suggest it be created soon.

@getdave
Copy link
Contributor

getdave commented Aug 23, 2021

Regarding "Check the filter to opt out works as expected" - what will the filter be named? I'd like to start adding that to sites I know won't be needing this feature to avoid possible issues. Knowing the name in advance will be super useful for people like me, so if it not yet determined then I'd like to suggest it be created soon.

This is the format used by the Widgets Editor

// Disables the block editor from managing widgets in the Gutenberg plugin.
add_filter( 'gutenberg_use_widgets_block_editor', '__return_false' );
// Disables the block editor from managing widgets.
add_filter( 'use_widgets_block_editor', '__return_false' );

Therefore we should probably follow the same format, namely:

// Disables the block editor from managing navigations in the Gutenberg plugin.
add_filter( 'gutenberg_use_navigation_block_editor', '__return_false' );
// Disables the block editor from managing navigations.
add_filter( 'use_navigation_block_editor', '__return_false' );

⚠️ We're not guaranteeing this at this point however. The opt in/out strategy might need to be different for the Nav Editor.

@superbmario
Copy link

I was wondering if the filters to disable the new Navigations editor are added yet. I cannot seem to find it in the source. I've opened a new issue to track just in case #37640

Thanks!

@draganescu
Copy link
Contributor Author

I will close this issue as it is referring to some really outdated information about the Navigation editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants