Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider showing the link url beside the icon when one is set in navigation #22836

Closed
karmatosed opened this issue Jun 2, 2020 · 4 comments
Closed

Consider showing the link url beside the icon when one is set in navigation #22836

karmatosed opened this issue Jun 2, 2020 · 4 comments
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@karmatosed
Copy link
Member

This feature might also expand to any link, but for now, I created a mock of what this might look like for navigation block.

Frame 4
@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label Jun 2, 2020
@richtabor
Copy link
Member

What if instead the link was added to a Tooltip of the link icon instead? 🤔

@draganescu
Copy link
Contributor

Exploring this in two "try" PR's would maybe give some direction?

@draganescu draganescu added [Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement. labels Jun 4, 2020
@draganescu draganescu mentioned this issue Jun 5, 2020
Closed
10 tasks
@adamziel adamziel mentioned this issue Jun 9, 2020
Closed
6 tasks
@mtias
Copy link
Member

mtias commented Jun 11, 2020

Could also expand in place on hover / focus if we find it's too much expanded by default. I think the url should strip out protocol from display.

@draganescu
Copy link
Contributor

I'll close this in favor of tracking #23375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@draganescu @adamziel @karmatosed @mtias @richtabor