Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LineHeight styles: Typography panel still visible after disabling #22602

Closed
ItsJonQ opened this issue May 25, 2020 · 0 comments · Fixed by #22605
Closed

LineHeight styles: Typography panel still visible after disabling #22602

ItsJonQ opened this issue May 25, 2020 · 0 comments · Fixed by #22605
Assignees
@ItsJonQ
Labels
[Block] Heading Affects the Headings Block [Block] Paragraph Affects the Paragraph Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@ItsJonQ
Copy link

ItsJonQ commented May 25, 2020

After disabling the new line-height style via...

add_theme_support( 'disable-custom-line-height' );

The Typography panel on the side renders as empty:

82829313-47410700-9eb3-11ea-89b7-7172dfd1bb14

Expected behavior

If line-height is disabled, and if the typography panel is empty, it should not render.

Reported by: @mariohamann

Originally mentioned:
#20339
@ItsJonQ ItsJonQ added [Type] Bug An existing feature does not function as intended [Block] Heading Affects the Headings Block [Block] Paragraph Affects the Paragraph Block labels May 25, 2020
@ItsJonQ ItsJonQ self-assigned this May 25, 2020
@ItsJonQ ItsJonQ mentioned this issue May 25, 2020
Merged
6 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ItsJonQ ItsJonQ

Labels
[Block] Heading Affects the Headings Block [Block] Paragraph Affects the Paragraph Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Typography panel rendering from style hooks WordPress/gutenberg
1 participant
@ItsJonQ