Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterating on the New Template Area (Partial) flow #21526

Closed
MichaelArestad opened this issue Apr 9, 2020 · 5 comments
Closed

Iterating on the New Template Area (Partial) flow #21526

MichaelArestad opened this issue Apr 9, 2020 · 5 comments
Assignees
Labels
Needs Dev Ready for, and needs developer efforts

Comments

@MichaelArestad
Copy link
Contributor

Here is a gif and an image of a new template area (partial) inserted into the site editor in Gutenberg (master):

2020-04-09 15 36 53

image

Proposal

This works well enough for demo purposes. Now, it's time to iterate on the process a bit. I propose we make some minor changes to make the process a little tidier. I put together a prototype using a design pattern from an issue iterating on the Inserter. It's not particularly relevant to this issue as the changes I'm proposing are limited to the moment after the Template area is inserted into the post.

Try the prototype.

2020-04-09 13 55 11

Lets not ask for the theme name. If it's necessary, that should be done behind the scenes. Let's not ask for a slug. Instead, we should generate a slug based on what the user names the template area (similar to how a site title translates into a URL).

Screenshot

image

@karmatosed
Copy link
Member

karmatosed commented Apr 27, 2020

Firstly, I love the reduction in things being asked for and move towards simply creating the template area. I also think a move to visual for this makes a lot of sense.

I wonder could this go further and just create the template area name, similar to reusable blocks where you edit after creation? I might be missing the benefit though of giving it a name first.

@mapk
Copy link
Contributor

mapk commented May 4, 2020

Lets not ask for the theme name. If it's necessary, that should be done behind the scenes. Let's not ask for a slug. Instead, we should generate a slug based on what the user names the template area (similar to how a site title translates into a URL).

Thanks Michael! I agree with all of this. Can we get this integrated sooner than later? I'd love to fiddle with this new interaction in the Site Editor.

@mapk mapk added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels May 4, 2020
@MichaelArestad
Copy link
Contributor Author

Can we get this integrated sooner than later? I'd love to fiddle with this new interaction in the Site Editor.

Sounds good to me!

@MichaelArestad
Copy link
Contributor Author

I've proposed an update to the design for this on a comment on #21218. For simplicity, I would like to keep conversation there.

@MichaelArestad
Copy link
Contributor Author

Resolved in #23295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

No branches or pull requests

3 participants