Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Update Design" checkboxes don't render properly in site editing #21168

Closed
mtias opened this issue Mar 26, 2020 · 2 comments
Closed

"Update Design" checkboxes don't render properly in site editing #21168

mtias opened this issue Mar 26, 2020 · 2 comments
Labels
[Type] Bug An existing feature does not function as intended

Comments

@mtias
Copy link
Member

mtias commented Mar 26, 2020

Are not loading relevant styles for when they are toggled.

image

@mtias mtias added the [Type] Bug An existing feature does not function as intended label Mar 26, 2020
@mtias mtias changed the title "Update Design" checkboxes in site editing "Update Design" checkboxes don't render properly in site editing Mar 29, 2020
@skorasaurus
Copy link
Member

skorasaurus commented Apr 7, 2020

Here's a very detailed report of this written by @JustinyAhin

Describe the bug
In Site Editor (beta) page, after editing the site, and clicking on the "Update Design" button, it is impossible to check on of the checkboxes of templates or templates parts in order to save the changes made.

To reproduce
Steps to reproduce the behavior:
On a fresh WordPress install,

Install and activate the Gutenberg Plugin
Go to Gutenberg > Experiments, and enable "Full site editing" and "Full site editing demo templates" option.
Go to Gutenberg > Site Editor (beta) and made some changes to the site in the block editor.
Click on "Update Design" button and try to check one of the checkboxes.

Expected behavior
We should be able to select one of the checkboxes (Template: Front Page and Template Part: Header) to save them.

Screencast
https://res.cloudinary.com/segbedji/video/upload/v1585841865/Gutenberg/Site_Editor_beta_Gutenberg_WordPress_-_Firefox_Developer_Edition_02_04_2020_16_30_28_v4whxh.mp4

Desktop

OS: Windows 10 Professional 1803
Browser: Firefox Developer Edition
Version: 75.0b11

Additional context

WordPress 5.4
Gutenberg 7.8.1

@mtias
Copy link
Member Author

mtias commented Apr 7, 2020

@skorasaurus this was fixed in #21159, so it'll be part of the next release.

@mtias mtias closed this as completed Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants