Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global styles: heading and text font families #21028

Closed
karmatosed opened this issue Mar 19, 2020 · 1 comment
Closed

Global styles: heading and text font families #21028

karmatosed opened this issue Mar 19, 2020 · 1 comment
Labels
[Block] Heading Affects the Headings Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Dev Ready for, and needs developer efforts

Comments

@karmatosed
Copy link
Member

I am pulling out each functionality to be added into global styles. This issue will focus on heading and text font families specifically.

Basic version

This has nothing extra, just a way to set font families:

image

Adding in line-height and styling

Perhaps a next step could be to add line-height and styling.

image

As fonts are adjusted, some control like this makes a lot of sense.

Adding in sizing

Whilst there is planned to be a scale to set sizing, bringing a way to set size on heading and text makes a lot of sense also. This is getting a quite intense interface, so looking at ways to ease through icons might be a good option here:

Frame 8

Full screen

This then looks in the context of global styles like this:

all

Feedback

A lot of conversation around this happened in #20367, it would be great to focus here and then get an implementation to see what this feels like.

  • This could have fonts declared by theme potentially.
  • The system fonts might be a good offer as basic options.
  • It would be good to decide how far we go on v1 here and then scale up what we offer, it might simply be offering the families.
@karmatosed karmatosed added the Needs Dev Ready for, and needs developer efforts label Mar 19, 2020
@mtias mtias mentioned this issue Mar 19, 2020
82 tasks
@karmatosed karmatosed added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Mar 19, 2020
@skorasaurus skorasaurus added the [Block] Heading Affects the Headings Block label Sep 8, 2021
@youknowriad
Copy link
Contributor

Screenshot 2023-05-08 at 3 03 39 PM

I think this issue has been solved some time ago, please let me know If I'm missing anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Heading Affects the Headings Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

No branches or pull requests

3 participants