Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation menu block: cannot select custom color #20810

Closed
enriquesanchez opened this issue Mar 11, 2020 · 5 comments
Closed

Navigation menu block: cannot select custom color #20810

enriquesanchez opened this issue Mar 11, 2020 · 5 comments
Labels
[Block] Navigation Affects the Navigation Block [Block] Paragraph Affects the Paragraph Block [Type] Bug An existing feature does not function as intended

Comments

@enriquesanchez
Copy link
Contributor

This issue comes from the the accessibility test performed by the Accessibility team (#20369).

In the color palette when you don't like the default colors offered, you need to open another popover and you can only use arrows keys to change the color. When I tab to use HEX section the popover closes.

2020-03-11 13-57-49 2020-03-11 13_59_19

If using a keyboard only, selecting a custom color is impossible because the custom color picker disappears and the focus returns to the first item of the color palette.

@enriquesanchez enriquesanchez added the [Block] Navigation Affects the Navigation Block label Mar 11, 2020
@mtias
Copy link
Member

mtias commented Mar 11, 2020

The custom color picker seems to be closing eagerly on almost every interface I've tried.

@karmatosed karmatosed added the [Type] Bug An existing feature does not function as intended label Mar 11, 2020
@talldan talldan added the [Block] Paragraph Affects the Paragraph Block label Mar 20, 2020
@talldan
Copy link
Contributor

talldan commented Mar 20, 2020

Seeing this in the paragraph block as well 😱.

This might be something solved by #19879.

Edit: doesn't seem to be solved by that, but it does seem to have been caused by a more recent change.

@sstabrizi
Copy link

Just adding a +1 that this is still an issue on the latest Gutenberg release. I encounter the problem in the Paragraph block when trying to change either the background color or text color. It did seem to work properly when trying to change the color for an individual word inside a paragraph block, which is new for this release.

@roo2
Copy link
Contributor

roo2 commented Mar 27, 2020

This is the same issue as #21163
It might be fixed by #21037

@tellthemachines
Copy link
Contributor

This issue can be closed now because the color select tools are no longer in the block toolbar, and color selection in the block inspector is working properly with the keyboard. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Paragraph Affects the Paragraph Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

7 participants