Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY up LinkControl normal and "Create" suggestions code #20271

Closed
Tracked by #35073
getdave opened this issue Feb 17, 2020 · 1 comment
Closed
Tracked by #35073

DRY up LinkControl normal and "Create" suggestions code #20271

getdave opened this issue Feb 17, 2020 · 1 comment
Assignees
@getdave
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting)

Comments

@getdave
Copy link
Contributor

getdave commented Feb 17, 2020

It would be nice if we could refactor to reduce the code duplication between this and the LinkControlSearchCreate above. It seems like the two receive largely the same props, with few exceptions.

Originally posted by @aduth in #19775

Should be a case of creating a common props object and spreading it onto the two components. There are only 3 shared props but it's probably worth it.
@getdave getdave self-assigned this Feb 17, 2020
@getdave getdave added the [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) label Feb 17, 2020
@getdave getdave mentioned this issue Feb 17, 2020
Merged
24 tasks
@youknowriad youknowriad mentioned this issue Jul 14, 2020
Merged
@adamziel adamziel mentioned this issue Jul 21, 2020
Closed
@fabiankaegy fabiankaegy mentioned this issue Sep 23, 2021
Open
39 tasks
@getdave
Copy link
Contributor Author

getdave commented Nov 14, 2021

This got cleaned up as part of general code maintenance

@getdave getdave closed this as completed Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getdave getdave

Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@getdave