Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wp-block-subhead class selectors in editor/block-library styles #19797

Closed
strarsis opened this issue Jan 21, 2020 · 3 comments
Closed

wp-block-subhead class selectors in editor/block-library styles #19797

strarsis opened this issue Jan 21, 2020 · 3 comments
Labels
[Type] Code Quality Issues or PRs that relate to code quality

Comments

@strarsis
Copy link
Contributor

strarsis commented Jan 21, 2020

Describe the bug
There are still styles targetting the wp-block-subhead class in the Gutenberg editor block-library styles.

To reproduce
Steps to reproduce the behavior:

  1. Insert cover block.
  2. Add some text to it.
  3. Inspect the text element.
  4. In developer tools, open the Computed tab.
  5. Expand color attribute.
  6. Notice that the inherit value stems from the Gutenberg editor block-library styles.css.

Expected behavior
As the Subhead block had been retired from Gutenberg for many months,
there shouldn't be any Subhead block related styles left, not even for backward compatibility,
because there had also been a deprecation phase.

@strarsis strarsis changed the title wp-block-subhead class in editor/block-library styles wp-block-subhead class selectors in editor/block-library styles Jan 21, 2020
@talldan
Copy link
Contributor

talldan commented Feb 6, 2020

Related - #19267

@talldan talldan added the [Type] Code Quality Issues or PRs that relate to code quality label Feb 6, 2020
@paaljoachim
Copy link
Contributor

I am seeing two issues that address similar concerns.

Pinging:
@WordPress/gutenberg-core

@youknowriad
Copy link
Contributor

At the moment, the block is still there to support old content. Until then we can't remove the styles. See #19267 for potential removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

No branches or pull requests

4 participants