Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping on columns block outlines #18872

Closed
karmatosed opened this issue Dec 2, 2019 · 4 comments
Closed

Overlapping on columns block outlines #18872

karmatosed opened this issue Dec 2, 2019 · 4 comments
Labels
[Block] Columns Affects the Columns Block

Comments

@karmatosed
Copy link
Member

This might need to link into another outline issue, but I noticed there is some rather confusing overlap going on for example with columns block and image:

image

cc @jasmussen for maybe looping this into another issue.

@karmatosed karmatosed added the [Block] Columns Affects the Columns Block label Dec 2, 2019
@jasmussen
Copy link
Contributor

The dashed outlines should have been made better by #18105, in that they should be gone, mitigating this issue. Is this master?

The thing is, those block outlines are all outset from the block footprint by 14px. Which means that if you select a block inside a column inside a columns block, there will essentially be conflicting stacked outlines. This is a strong argument for rethinking the block outlines in #18667 in two ways:

  • Fewer. This isn't helping anyone.
  • Perhaps reduce to just the block footprint, so we don't get this overlapping behavior.
  • Show only when actually necessary.

@karmatosed
Copy link
Member Author

This is master, unfortunately.

@jasmussen
Copy link
Contributor

That's weird, I'm seeing this from having compiled just now:

Screenshot 2019-12-02 at 18 28 27

Could it be you've fetched a different origin of master? Or perhaps just need a fresh pull?

@karmatosed
Copy link
Member Author

Ah ok, this is weird but good. I just grabbed again, npm installed and this is what see:

image

I will close this out as seems my original issue is fixed but there is still room to iterate here. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block
Projects
None yet
Development

No branches or pull requests

2 participants