Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Size Picker: The selected preset doesn't change to Custom when picking a random value #18211

Closed
gziolo opened this issue Oct 31, 2019 · 3 comments
Closed

Font Size Picker: The selected preset doesn't change to Custom when picking a random value #18211

gziolo opened this issue Oct 31, 2019 · 3 comments
Labels
[Feature] UI Components Impacts or related to the UI component system Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Package] Components /packages/components Storybook Storybook and its stories for components [Type] Bug An existing feature does not function as intended

Comments

@gziolo
Copy link
Member

gziolo commented Oct 31, 2019 •
edited
Loading

Describe the bug
Originally reported in #18149:

The selected preset doesn't change to Custom when I pick a random value:
Screen Shot 2019-10-31 at 10 39 23

To reproduce
Steps to reproduce the behavior:

  1. Run Storybook: npm run design-system:dev or open https://wordpress.github.io/gutenberg/design-system/components/.
  2. Go to the FontSizePicker section.
  3. Pick the one named Default
  4. Change the value of the picker to something which the select box doesn't cover, e.g. 77.
  5. Observe that the preset doesn't update to Custom.

Expected behavior
The selected preset should change to Custom.

Desktop (please complete the following information):

  • OS: macOS
  • Browser Chrome
  • Version 77
@gziolo gziolo added [Type] Bug An existing feature does not function as intended [Feature] UI Components Impacts or related to the UI component system [Package] Components /packages/components labels Oct 31, 2019
@gziolo gziolo mentioned this issue Oct 31, 2019
Merged
@gziolo gziolo added Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts Storybook Storybook and its stories for components labels Oct 31, 2019
@Clarity-89
Copy link

@gziolo did you mean withSlider component since that's what corresponds to your screenshot? It seems like the slider isn't connected to input/select dropdown because it uses the onChange prop directly and not onChangeValue function.

I'm happy to submit a fix for it if that's ok.

@gziolo
Copy link
Member Author

gziolo commented Oct 31, 2019

@Clarity-89 - feel free to work on it. I didn't investigate closer. It should be easier to integrate. If 2 Gutenberg team members didn't catch it, then it's very unlikely that it's going to be a smooth process for other folks.

@Clarity-89 Clarity-89 mentioned this issue Oct 31, 2019
Closed
5 tasks
@gziolo
Copy link
Member Author

gziolo commented Apr 28, 2020

It's no longer an issue. I re-tested it.

@gziolo gziolo closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] UI Components Impacts or related to the UI component system Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Package] Components /packages/components Storybook Storybook and its stories for components [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove state from FontSizePicker Clarity-89/gutenberg
2 participants
@gziolo @Clarity-89