Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Links Block: Add additional flex-based alignments in the Inspector #17275

Closed
jasmussen opened this issue Aug 30, 2019 · 3 comments
Closed

Social Links Block: Add additional flex-based alignments in the Inspector #17275

jasmussen opened this issue Aug 30, 2019 · 3 comments
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

jasmussen commented Aug 30, 2019 •
edited
Loading

In #16897 a "social links" block is likely to land in its first version.

Based on feedback for that first version, we'd like to explore some additional features.

One of these being to allow additional flex-based button alignments in the inspector. At launch it will have left/center/right alignments, but it would be nice to have additional controls such as "space between".

Combined with a icon size control (#17276), this could allow for finegrained control.
@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label Aug 30, 2019
@jasmussen jasmussen mentioned this issue Aug 30, 2019
Merged
5 tasks
@jasmussen jasmussen mentioned this issue Sep 25, 2019
Closed
@jasmussen jasmussen mentioned this issue Oct 23, 2020
Merged
@skorasaurus skorasaurus added the [Block] Social Affects the Social Block - used to display Social Media accounts label Nov 25, 2020
@MaggieCabrera
Copy link
Contributor

Other blocks that could use space between as an alignment would be Navigation (#27132) and the buttons block too

@scruffian scruffian mentioned this issue Nov 27, 2020
Open
53 tasks
@jasmussen
Copy link
Contributor Author

Also potentially related, #27324 and conversations around unifying flex containers. CC: @shaunandrews

@jasmussen jasmussen mentioned this issue Jan 14, 2021
Merged
@jasmussen
Copy link
Contributor Author

Space between has landed for social icons! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skorasaurus @jasmussen @MaggieCabrera