Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation menu block: URL & permalink structure #17204

Closed
sarahmonster opened this issue Aug 26, 2019 · 1 comment
Closed

Navigation menu block: URL & permalink structure #17204

sarahmonster opened this issue Aug 26, 2019 · 1 comment
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback.

Comments

@sarahmonster
Copy link
Member

sarahmonster commented Aug 26, 2019

From #16821:

URL and permalink structure

First iteration should offer a link in sidebar to the permalink page.
Any changes in the settings should reflect in the Nav block.

I'm not entirely clear on what we're asking for here, so I'd appreciate some clarification (cc @mtias @mapk @karmatosed). I'm going to do my best to guess what we're looking for for each item though, so we can move forward.

First iteration should offer a link in sidebar to the permalink page.

I think this means that we want to show a link to the page in the sidebar when the menu item is selected, like this:

Screenshot 2019-08-26 at 14 05 34

Is my understanding here correct, or are we looking for something different? It probably makes more sense to offer a link to the current page right next to the control for editing that link, so that users can contextualise the link better, but I'd expect to be able to edit that link in the block toolbar or in an inline way, rather than in the sidebar. (We might get more clarity here from #17116 once we have clear direction there.)

Any changes in the settings should reflect in the Nav block.

I think this just means "if I update my page URL, the link to that page in my menu also changes". If that's the case, I'm 100% in agreement there, and that's what I expected would happen. I'm not sure if we need any design revisions or visual mockups to show this though.

A related question is "what happens if I change the title of the page", in which case I'd suggest that we follow this flow:

Flow showing choices if menu item source reference page is edited, and effect on menu item

Basically, if the user changes the url of a page, we'd always update the link in the menu, so that it points to the intended page. If they've changed the menu item label so it no longer matches the page title (so I may change a page with a title of "Homepage" and give it the label "Home"), the edited label stays. If they haven't edited the label, the label updates to match the new page title.

@swissspidy swissspidy added the [Block] Navigation Affects the Navigation Block label Aug 27, 2019
@sarahmonster sarahmonster added the Needs Design Feedback Needs general design feedback. label Sep 11, 2019
@noisysocks
Copy link
Member

Closing this for now as it's not totally clear what is needed. #17544 tracks the effort towards a v1 of the Navigation block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

3 participants