-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacer block: Can't grab the block's height adjuster #16646
Comments
This is pretty annoying. |
Discussed during today's Design triage in Slack. The team agreed that this was a larger issue around the placement of the appender. A couple of suggestions came up:
Concerns about accessibility and mobile support should be considered. |
Let's try how a delay of 2s or so feels for this. It might give a decent baseline since it'd appear when you want to, but not be in the way during most common operations. |
…doesn't interfere with other UI elements. Kind of fixes #16646. I wanted to try a delay on the inserter, but animating the display attribute in CSS isn't possible. I think that's why the Inserter uses the opacity instead, but opacity still takes up space even when opacity is set to 0.
Looks great, Shaun. A question will likely surface whether this makes it harder to get to the sibling inserter. Which it might. But at the same time it also makes the act of inserting between two blocks more intentional and less fiddly, and opens up blocks like #17143 for happening. In that vein, I would suggest this is a fine tradeoff to make. What's the next step to get this shipping? I'll juggle some labels. |
...and...
Exactly! This does make it harder to find the sibling inserter — and we may want to look at adding a tip about this somewhere — but it also makes the pattern a little more intentional and understandable once learned. It also reduces the amount of "stuff" that pops in-and-out when moving a cursor around a page with lots of blocks. |
* Reduce the padding around the sibling inserter icon so that the icon doesn't interfere with other UI elements. Kind of fixes #16646. I wanted to try a delay on the inserter, but animating the display attribute in CSS isn't possible. I think that's why the Inserter uses the opacity instead, but opacity still takes up space even when opacity is set to 0. * Switched hard coded padding number to existing variable.
I'm going to reopen this one. #17136 was an improvement, but it still requires some very careful mousework to differentiate between the resizer and the inserter. |
This seems to be working fairly well now with the latest design adjustments. There's probably some further improvements that could be done to the in-between inserter in general. |
Describe the bug
I can't grab the block's height adjuster due to the block below showing the Insert block appender over it.
To reproduce
Steps to reproduce the behavior:
Expected behavior
I expected to be able to grab the node to the adjuster without it being hidden under the block appender.
Screenshots
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: